More robust fix for re-export of __all__ #20487
Merged
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Dec 30, 2025
| self.incomplete_namespaces = incomplete_namespaces | ||
| self.all_exports: list[str] = [] | ||
| # Map from module id to list of explicitly exported names (i.e. names in __all__). | ||
| # This is used by stubgen/stubtest, DO NOT use for any other purposes as it is |
Collaborator
There was a problem hiding this comment.
Suggested change
| # This is used by stubgen/stubtest, DO NOT use for any other purposes as it is | |
| # This is used by stubgen, DO NOT use for any other purposes as it is |
Collaborator
There was a problem hiding this comment.
looks like it should be easy to remove this from stubgen entirely, i can make a PR after this is merged
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 30, 2025
Follow up to python#20487
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 30, 2025
Follow up to python#20487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to re-enable one test skipped in parallel mode.
The previous solution for re-export of
__all__(see #10382) didn't work on incremental runs (see added test).